fix(create): add vp create e2e tests and fix yarn/bun migration bugs#1317
Open
fix(create): add vp create e2e tests and fix yarn/bun migration bugs#1317
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fengmk2
force-pushed
the
add-vp-create-e2e
branch
from
b6bb893 to
fe223c7
Compare
fengmk2
force-pushed
the
add-vp-create-e2e
branch
from
79206b2 to
a938cf5
Compare
fengmk2
changed the title
vp create across all templates and package managers
…nagers Test all 3 built-in templates (monorepo, application, library) with all 4 package managers (pnpm, npm, yarn, bun) using the same tgz-packaging approach as ecosystem-ci. Each test verifies project structure, lockfiles, local package installation, and successful builds.
Split template-args from create-args so --package-manager is placed before the -- separator. Move VP_OVERRIDE_PACKAGES/VP_VERSION to job-level env. Add ls -la for debugging lockfile issues.
- Add VP_FORCE_MIGRATE=1 so the library template's existing vite-plus dep gets overridden with the local tgz (fixes all 4 library tests) - Exclude yarn (all templates): yarn install fails with absolute file: paths to tgz files - Exclude bun monorepo: migration writes empty catalog with catalog: references when using file: protocol
…empty catalog When VP_OVERRIDE_PACKAGES uses file: protocol paths (e.g., in CI with local tgz packages), rewriteBunCatalog() was unconditionally setting all overrides to 'catalog:' while skipping file: entries from the catalog itself, resulting in unresolvable 'catalog:' references pointing to an empty catalog. Now file: paths are used directly in overrides, matching npm behavior.
Two issues caused yarn install to fail in CI for newly created projects: 1. In CI (CI=true), yarn Berry defaults to enableImmutableInstalls which prevents creating a new lockfile. Pass --no-frozen-lockfile to vp install since vp create always needs to generate a fresh lockfile. 2. Standalone yarn projects had no .yarnrc.yml created during migration. Without nodeLinker: node-modules, yarn 4 defaults to PnP which doesn't work with vite-plus. Now rewriteYarnrcYml() ensures nodeLinker is set and is called for standalone projects too. Also removes all yarn exclusions from the create e2e test workflow (full 12-job matrix now enabled).
… .yarnrc.yml Revert passing --no-frozen-lockfile to vp install from vp create. Instead, set enableImmutableInstalls: false in .yarnrc.yml so yarn Berry can create/update lockfiles in CI where it defaults to immutable.
Let yarn Berry use its default behavior to see what errors occur in CI with immutable installs enabled.
Yarn Berry defaults to enableImmutableInstalls in CI, preventing lockfile creation. Pass --no-frozen-lockfile when CI env is set so vp create can generate fresh lockfiles.
Pass --no-frozen-lockfile to vp install only from vp create in CI, so yarn Berry can create fresh lockfiles without affecting vp install behavior in other contexts.
This reverts commit d67b5be.
Yarn Berry enables hardened mode on public PRs which blocks lockfile creation (YN0028). Set YARN_ENABLE_HARDENED_MODE=0 so vp create can generate fresh lockfiles in the e2e test.
Step-level env with value '0' wasn't propagated through the vp create → vp install → yarn install chain. Move to job-level env with boolean false so it's available to all child processes.
fengmk2
force-pushed
the
add-vp-create-e2e
branch
from
7de2e6c to
174331e
Compare
fengmk2
changed the title
fengmk2
changed the title
Yarn Berry's hardened mode on public PRs forbids lockfile creation but allows updating an existing one. The YARN_ENABLE_HARDENED_MODE env var cannot override this auto-detection. Instead, create an empty yarn.lock during migration so yarn install treats it as an update.
--no-immutable via --no-frozen-lockfile handles yarn's hardened mode, making the empty yarn.lock creation unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivated by #1297 the
.yarnrctemplate fix revealed thatvp createhad no e2e test coverage, making it easy for template bugs to ship undetected.test-vp-create.yml) that e2e testsvp createacross all 3 built-in templates (monorepo, application, library) and all 4 package managers (pnpm, npm, yarn, bun) — 12 test combinationscatalogwith danglingcatalog:references when usingfile:protocol.yarnrc.ymlwithnodeLinker: node-modules--no-frozen-lockfilefromvp createin CI so yarn Berry can create fresh lockfilesChanges
New:
vp createe2e test workflowvp createwithVP_OVERRIDE_PACKAGES/VP_VERSIONpointing to local packagesvite-plus@0.0.0installed,vp check, and build/test commandsvp run readytwice and assert 100% cache hit on the second runtest: create-e2elabel, or create-related file changesFix: bun monorepo catalog with
file:protocolrewriteBunCatalog()unconditionally set all overrides tocatalog:but skippedfile:entries from the catalog, leaving unresolvable referencesfile:paths directly in overrides when the value starts withfile:Fix: yarn standalone projects
rewriteYarnrcYml()now setsnodeLinker: node-moduleswhen absent (yarn 4 defaults to PnP)rewriteStandaloneProject()now callsrewriteYarnrcYml()for yarn projects (previously only called for monorepos)vp createpasses--no-frozen-lockfiletovp installin CI environmentsTest plan
vp test run packages/cli/src/migration/)bun-catalog-file-protocol.spec.tstest verifies the bun override fix🤖 Generated with Claude Code